ffi: preserve strings during reentrant calls#64551
Open
trivikr wants to merge 1 commit into
Open
Conversation
Cache temporary string conversion buffers by wrapper and active call depth. This prevents nested FFI calls from overwriting or replacing buffers still in use by an outer native call. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.6-sol
Collaborator
|
Review requested:
|
nodejs-github-bot
added
ffi
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64551 +/- ##
==========================================
+ Coverage 90.21% 90.24% +0.02%
==========================================
Files 739 739
Lines 241650 241737 +87
Branches 45542 45560 +18
==========================================
+ Hits 218013 218147 +134
+ Misses 15155 15119 -36
+ Partials 8482 8471 -11
🚀 New features to boost your workflow:
|
ShogunPanda
approved these changes
Jul 17, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
trivikr
added
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64550
Temporary buffers used to convert JavaScript strings for Fast FFI calls were
cached per library and argument index. A reentrant callback could make another
FFI call using the same argument index, overwriting or replacing a buffer still
in use by the outer native call.
This changes the cache to be scoped by FFI wrapper and active call depth. Each
reentrant invocation therefore receives separate string storage while buffers
remain reusable across non-overlapping calls.
Assisted-by: openai:gpt-5.6-sol